move lit properties to UmbLitElement #832
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
we cannot have lit properties on the UmbElementMixin since we are not guaranteed it's a Lit element
…the document, and lastly default 'en-us'
… in order not to call next() a million times
…, so no need to observe the 'lang' attribute this might change in the future if we separate loading of languages from changing of languages
…e moment, so no need to observe the 'lang' attribute" This reverts commit 6f07663.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
we cannot have lit properties on the UmbElementMixin since we are not guaranteed it's a Lit element